-
Notifications
You must be signed in to change notification settings - Fork 853
Reset scale of exponential histogram #6557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset scale of exponential histogram #6557
Conversation
…m/hannahhaering/opentelemetry-dotnet into exponential-histogram-reset-scale
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6557 +/- ##
==========================================
+ Coverage 86.38% 86.69% +0.30%
==========================================
Files 258 258
Lines 11909 11910 +1
==========================================
+ Hits 10288 10325 +37
+ Misses 1621 1585 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me. Please update the CHANGELOG.
src/OpenTelemetry/Metrics/MetricPoint/Base2ExponentialBucketHistogram.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Martin Costello <[email protected]>
|
Thank you for your contribution @hannahhaering! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
….12.0 to 1.13.1 (#64) Updated [OpenTelemetry.Exporter.OpenTelemetryProtocol](https://github.com/open-telemetry/opentelemetry-dotnet) from 1.12.0 to 1.13.1. <details> <summary>Release notes</summary> _Sourced from [OpenTelemetry.Exporter.OpenTelemetryProtocol's releases](https://github.com/open-telemetry/opentelemetry-dotnet/releases)._ ## 1.13.1 For highlights and announcements pertaining to this release see: [Release Notes > 1.13.1](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/RELEASENOTES.md#1131). The following changes are from the previous release [1.13.0](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.13.0). * NuGet: [OpenTelemetry v1.13.1](https://www.nuget.org/packages/OpenTelemetry/1.13.1) * Fixed an issue where the Base2 Exponential Bucket Histogram did not reset its scale to 20 after each collection cycle when using delta aggregation temporality. ([#6557](open-telemetry/opentelemetry-dotnet#6557)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.13.1/src/OpenTelemetry/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api v1.13.1](https://www.nuget.org/packages/OpenTelemetry.Api/1.13.1) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.13.1/src/OpenTelemetry.Api/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api.ProviderBuilderExtensions v1.13.1](https://www.nuget.org/packages/OpenTelemetry.Api.ProviderBuilderExtensions/1.13.1) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.13.1/src/OpenTelemetry.Api.ProviderBuilderExtensions/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Console v1.13.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Console/1.13.1) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.13.1/src/OpenTelemetry.Exporter.Console/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.InMemory v1.13.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.InMemory/1.13.1) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.13.1/src/OpenTelemetry.Exporter.InMemory/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.OpenTelemetryProtocol v1.13.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.OpenTelemetryProtocol/1.13.1) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.13.1/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Zipkin v1.13.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Zipkin/1.13.1) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.13.1/src/OpenTelemetry.Exporter.Zipkin/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Extensions.Hosting v1.13.1](https://www.nuget.org/packages/OpenTelemetry.Extensions.Hosting/1.13.1) ... (truncated) ## 1.13.1-beta.1 The following changes are from the previous release [1.13.0-beta.1](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/coreunstable-1.13.0-beta.1). * NuGet: [OpenTelemetry.Exporter.Prometheus.AspNetCore v1.13.1-beta.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Prometheus.AspNetCore/1.13.1-beta.1) * Updated OpenTelemetry core component version(s) to `1.13.1`. ([#6598](open-telemetry/opentelemetry-dotnet#6598)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.13.1-beta.1/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Prometheus.HttpListener v1.13.1-beta.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Prometheus.HttpListener/1.13.1-beta.1) * Updated OpenTelemetry core component version(s) to `1.13.1`. ([#6598](open-telemetry/opentelemetry-dotnet#6598)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.13.1-beta.1/src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Shims.OpenTracing v1.13.1-beta.1](https://www.nuget.org/packages/OpenTelemetry.Shims.OpenTracing/1.13.1-beta.1) * Updated OpenTelemetry core component version(s) to `1.13.1`. ([#6598](open-telemetry/opentelemetry-dotnet#6598)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.13.1-beta.1/src/OpenTelemetry.Shims.OpenTracing/CHANGELOG.md) for details. ## 1.13.0 For highlights and announcements pertaining to this release see: [Release Notes > 1.13.0](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/RELEASENOTES.md#1130). The following changes are from the previous release [1.12.0](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.12.0). * NuGet: [OpenTelemetry v1.13.0](https://www.nuget.org/packages/OpenTelemetry/1.13.0) * Added a verification to ensure that a `MetricReader` can only be registered to a single `MeterProvider`, as required by the OpenTelemetry specification. ([#6458](open-telemetry/opentelemetry-dotnet#6458)) * Added `FormatMessage` configuration option to self-diagnostics feature. When set to `true` (default is false), log messages will be formatted by replacing placeholders with actual parameter values for improved readability. Example `OTEL_DIAGNOSTICS.json`: ```json { "LogDirectory": ".", "FileSize": 32768, "LogLevel": "Warning", "FormatMessage": true } ``` * Fixed parsing of `OTEL_TRACES_SAMPLER_ARG` decimal values to always use `.` as the delimiter when using the `traceidratio` sampler, preventing locale-specific parsing issues. ([#6444](open-telemetry/opentelemetry-dotnet#6444)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.13.0/src/OpenTelemetry/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api v1.13.0](https://www.nuget.org/packages/OpenTelemetry.Api/1.13.0) * Added `AddLink(SpanContext, SpanAttributes?)` to `TelemetrySpan` to support linking spans and associating optional attributes for advanced trace relationships. ([#6305](open-telemetry/opentelemetry-dotnet#6305)) * Experimental (only in pre-release versions): Added the `EventName` property to `LogRecordData` ([#6306](open-telemetry/opentelemetry-dotnet#6306)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.13.0/src/OpenTelemetry.Api/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Api.ProviderBuilderExtensions v1.13.0](https://www.nuget.org/packages/OpenTelemetry.Api.ProviderBuilderExtensions/1.13.0) No notable changes. See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/core-1.13.0/src/OpenTelemetry.Api.ProviderBuilderExtensions/CHANGELOG.md) for details. ... (truncated) ## 1.13.0-beta.1 The following changes are from the previous release [1.12.0-beta.1](https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/coreunstable-1.12.0-beta.1). * NuGet: [OpenTelemetry.Exporter.Prometheus.AspNetCore v1.13.0-beta.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Prometheus.AspNetCore/1.13.0-beta.1) * Updated OpenTelemetry core component version(s) to `1.13.0`. ([#6552](open-telemetry/opentelemetry-dotnet#6552)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.13.0-beta.1/src/OpenTelemetry.Exporter.Prometheus.AspNetCore/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Exporter.Prometheus.HttpListener v1.13.0-beta.1](https://www.nuget.org/packages/OpenTelemetry.Exporter.Prometheus.HttpListener/1.13.0-beta.1) * Updated OpenTelemetry core component version(s) to `1.13.0`. ([#6552](open-telemetry/opentelemetry-dotnet#6552)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.13.0-beta.1/src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md) for details. * NuGet: [OpenTelemetry.Shims.OpenTracing v1.13.0-beta.1](https://www.nuget.org/packages/OpenTelemetry.Shims.OpenTracing/1.13.0-beta.1) * Updated OpenTelemetry core component version(s) to `1.13.0`. ([#6552](open-telemetry/opentelemetry-dotnet#6552)) See [CHANGELOG](https://github.com/open-telemetry/opentelemetry-dotnet/blob/coreunstable-1.13.0-beta.1/src/OpenTelemetry.Shims.OpenTracing/CHANGELOG.md) for details. Commits viewable in [compare view](open-telemetry/opentelemetry-dotnet@core-1.12.0...core-1.13.1). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rene Bentes Pinto <[email protected]>
Fixes #5635
Changes
Reset scale to 20 of the Base2 Exponential Bucket Histogram after each collection cycle when using delta aggregation temporality.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes